Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ID Types Support #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmosorast
Copy link
Contributor

Description of change

The tap currently cannot support multiple data types in the _id field for FULL_TABLE replication, due to the behavior of MongoDB when comparing differing types (e.g., ObjectId and String). In this case it returns false for both less than and greater than, effectively filtering out the _ids of the differing type from the max _id during full table sync.

This PR contains a broken test that should be fixed by the solution to this issue, in a way that is generic for all users of mongodb and tap-mongodb.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Relatively high, this code is hit by a lot of users of the tap.

Rollback steps

  • revert this branch

@dmosorast dmosorast added the help wanted Extra attention is needed label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant